-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show deprecated concepts without replacement in change list #1529
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1529 +/- ##
=========================================
Coverage 70.08% 70.08%
- Complexity 1658 1659 +1
=========================================
Files 32 32
Lines 4272 4272
=========================================
Hits 2994 2994
Misses 1278 1278
☔ View full report in Codecov by Sentry. |
Hi Osma, Thank you for fixing the issue. May I ask whether the fix will be part of/visble in version 2.17 or only from version 3.0 onwards, thanks. Best wishes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (even though switching to Skosmos 2 for testing was a bit twiddly)
This will first be fixed on the development branch ( The same fix has to be done for Skosmos 3 as well so we don't lose the improved functionality. For now this means only porting the back-end parts, because the change list is not yet implemented in the new Skosmos 3 front-end. |
Reasons for creating this PR
It was reported in #1513 that
This PR fixes the problem by making sure that deprecated concepts which do not have an isReplacedBy relationship are shown. For example "elevated tracks" in this screenshot is a deprecated concept which doesn't have a replacement (I removed it manually from the YSO version I used for testing):
I verified that the performance of the "New and Deprecated" page is unchanged; possibly it is actually slightly better (1.4 seconds instead of 1.5 for the test case I used).
Link to relevant issue(s), if any
Description of the changes in this PR
changes
test vocabulary adding a deprecated concept without isReplacedBy and add tests to check that it is included as well (I had to adjust other unit tests that broke due to the changes in the test vocabulary)Known problems or uncertainties in this PR
The same or similar changes need to be repeated for Skosmos 3 as well.
Checklist
.sr-only
class, color contrast)