Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue913 deprecated concepts number #1174

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Conversation

Vainonen
Copy link
Contributor

Fixes #913 by adding number of deprecated concepts into vocabulary info page under "Resource counts by type". Number of deprecated concepts by concept subtypes and number of deprecated collections is added to REST API responses.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #1174 (faf465e) into master (4a050f4) will increase coverage by 0.86%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1174      +/-   ##
============================================
+ Coverage     67.97%   68.83%   +0.86%     
- Complexity     1584     1586       +2     
============================================
  Files            32       32              
  Lines          3888     3896       +8     
============================================
+ Hits           2643     2682      +39     
+ Misses         1245     1214      -31     
Impacted Files Coverage Δ
model/Vocabulary.php 87.85% <ø> (ø)
controller/RestController.php 19.45% <50.00%> (+6.42%) ⬆️
model/sparql/GenericSparql.php 92.14% <90.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a050f4...faf465e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 8 Security Hotspots
Code Smell B 19 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@osma osma merged commit f690b72 into master Jun 2, 2021
@osma osma deleted the issue913-deprecated-concepts-number branch June 2, 2021 12:03
@osma osma added this to the 2.11 milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclusion/expression of deprecated concepts in ontology metadata
2 participants