Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to define parameter plugins outside of the orde… #1278

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Mar 2, 2022

Added the possibility to define parameter plugins outside of the ordered plugin list

Reasons for creating this PR

After the recent changes with including the option for giving an order for the list of plugins, it was not possible to define parameter plugins without listing them in the ordered list. This was a loss of previous functionality, which this PR aims to revive.

Link to relevant issue(s), if any

This PR addresses #1148 but does not fix it.

Description of the changes in this PR

Added the separate handling of parameter plugins to getPluginArray(), as previously it only took account the ordered list of skosmos:vocabularyPlugins and the skosmos:globalPlugins.

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added this to the 2.14 milestone Mar 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1278 (5ce6c74) into master (da1716c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1278      +/-   ##
============================================
+ Coverage     69.36%   69.39%   +0.03%     
- Complexity     1649     1651       +2     
============================================
  Files            32       32              
  Lines          4047     4051       +4     
============================================
+ Hits           2807     2811       +4     
  Misses         1240     1240              
Impacted Files Coverage Δ
model/VocabularyConfig.php 96.18% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1716c...5ce6c74. Read the comment docs.

@joelit joelit self-assigned this Mar 2, 2022
@joelit joelit linked an issue Mar 2, 2022 that may be closed by this pull request
@osma osma merged commit cba30a7 into master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Order of vocabulary-specific plugins is not configurable
2 participants