-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sidebar search, post bootstrap #1314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1314 +/- ##
=========================================
Coverage 70.36% 70.36%
Complexity 1649 1649
=========================================
Files 32 32
Lines 3790 3790
=========================================
Hits 2667 2667
Misses 1123 1123 Continue to review full report at Codecov.
|
Thanks a lot @kinow ! Will test... |
I tested this briefly. Here you can see the old Skosmos 2.14 (left) and new (right): EDIT: Changed the picture, I first pasted in the wrong one by mistake. It's working well now! The font color is different for the options - it used to be blue (link color) but now it's black. I think the black color is better actually. These are not links so there is no reason to use blue color. Also the highlighting is different, but here too I think the new look is better. For the group selection, I suggest changing the square checkboxes to round radio buttons, as they used to be. This is because only one selection is allowed. For the others, the square checkboxes are good. In general there is a little bit more vertical spacing in the new layout, for example between the labels and the selection boxes (highlighted on picture). It's the same with the search results seen on the right - they take up more space than they used to. For example the headline "catacombs" is visible in the old layout on the left side but not in the new layout on the right side. I wonder if there is some general CSS setting (line-height maybe?) that is different in Bootstrap 5 than it used to be in Bootstrap 3? This isn't super critical, just something I wonder about because it seems to affect all page types, not just the search result page shown here. |
👍
I will spend some time touching up after fixing the checkbox/radiobutton, trying to make it look more similar to finto. Can probably finish it tomorrow morning (not working, and my soccer team is playing in Sao Paulo, so eyes on the screen, ears to the radio ⚽ ) Thanks for testing it so quickly @osma! |
Huh, interesting. Looking at the HTML DOM, the "By group" fields are actually using One CSS rule that I added to have sharp corners in the checkboxes ended up causing the radio inputs to have sharp corners too. Essentially becoming check boxes 😆 Fixed. Now looking at the remaining style issues. |
46a8b00
to
c2cf6c9
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Bootstrap 5 had a class Some screenshots. Had a look at the Feedback form and at the search language switcher to see if these changes broke those Ready for review again 🎉 |
Excellent work @kinow! All good now, I'm merging this. |
Reasons for creating this PR
Bootstrap upgrade PR broke the sidebar search (completely forgot to test this part during the Bootstrap upgrade! Sorry 😨 )
Link to relevant issue(s), if any
Description of the changes in this PR
Fix sidebar search, by matching previous CSS styles. Had to modify the structure of HTML, and copy the
btn-default
style from Bootstrap 3.Known problems or uncertainties in this PR
Checklist