Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll hierarchy to selected concept instead of children #1374

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

osma
Copy link
Member

@osma osma commented Oct 6, 2022

Reasons for creating this PR

Follow-up fix to #1372. The scrolling was off if the concept has many descendants in the hierarchy. This PR adjusts the selector so that the scrolling ends up in the right position.

Link to relevant issue(s), if any

Description of the changes in this PR

  • adjust jQuery selector used to determine auto-scroll position

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Oct 6, 2022
@osma osma added this to the 2.16 milestone Oct 6, 2022
@osma osma self-assigned this Oct 6, 2022
@osma osma merged commit e4fd30e into master Oct 6, 2022
@osma osma deleted the fix-hierarchy-scroll-position branch October 6, 2022 07:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant