Fix feedback form limit php81 deprecation warning #1567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Follow-up fix to PR #1566 to address PHP 8.1 deprecation warnings. That PR used
substr
for truncation in a way that could trigger deprecation warnings whennull
values were encountered. This PR instead adds amaxlimit
parameter to the Request.getQueryParamPOST method and uses that instead of plain substr, avoiding the problem.Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
n/a
Checklist
.sr-only
class, color contrast)