-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO: improved titles for Skosmos 3 generated HTML pages #1625
Conversation
cfa6ebc
to
bdd60b3
Compare
Quality Gate failedFailed conditions |
@@ -1,6 +1,6 @@ | |||
{% set pageType = 'error' %} | |||
{% extends "base-template.twig" %} | |||
{% block title %}: "Error"{% endblock %} | |||
{% block title %}{{ "Error"| trans }} - {{ GlobalConfig.serviceName }}{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There does not seem to be a translation string for 'Error':
- I tried with pages like https://localhost/Skosmos/yso/fi/p%C3%A5ge/p23406
- Then again,
grep -C 1 'Error' skosmos_fi.po
didn't show a msg-id that would be just 'Error'
The 'error' msgid should probably be added to the translation templates.
Converting back to draft, because I still need to:
|
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reasons for creating this PR
Improve search engine optimization in Skosmos 3 by making the
<title>
values and related metadata (title
,twitter:title
,og:title
) conform to the specification in #1533 (comment) .This PR only handles the titles, not descriptions. The descriptions will have to be implemented in a subsequent PR.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Checklist
.sr-only
class, color contrast)