-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO: descriptions on landing, about and feedback pages #1647
Conversation
757d205
to
c9dd489
Compare
Quality Gate failedFailed conditions |
Rebased on current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests (back-end & front-end) passed and the code and implementation look good. I think it can be merged, but maybe you could add descriptions to the Skosmos wiki? Good job!
I added wiki documentation to the checklist in the main SEO issue: #1533 (comment) Yes, obviously the documentation should explain that these configuration settings are related to SEO. |
Reasons for creating this PR
This PR adds support for new SEO configuration options
skosmos:serviceDescription
,skosmos:aboutDescription
andskosmos:feedbackDescription
which make it possible to set a description for the landing, about and feedback pages, respectively. The values are multilingual. If not set, there will be no description metadata on the respective page.Link to relevant issue(s), if any
Description of the changes in this PR
skosmos:serviceDescription
,skosmos:aboutDescription
andskosmos:feedbackDescription
settings in GlobalConfigKnown problems or uncertainties in this PR
There is no Cypress test for the case when one of the descriptions is not set in the configuration and thus should not be displayed. Should there be? The problem here is that this would require a separately configured Skosmos instance with a different configuration that omits some or all of the description settings. We currently only use one Skosmos instance for running Cypress tests, using the
tests/testconfig.ttl
configuration file.Checklist
.sr-only
class, color contrast)