Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO: add description metadata to concept page #1659

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

osma
Copy link
Member

@osma osma commented Aug 21, 2024

Reasons for creating this PR

Adding one final missing piece of SEO functionality: description metadata on the concept page.

The description is translated using the normal translation mechanism. The current translations are:

  • Finnish: Käsite xxxx sanastossa yyyy
  • Swedish: Begreppet xxxx i vokabulären yyyy
  • English: Concept xxxx in vocabulary yyyy
  • Northern Sámi: Doaba xxxx sátnerájus yyyy

where xxxx is the prefLabel of the concept and yyyy is the title (not the short name) of the vocabulary, as specified earlier in #1533.

Link to relevant issue(s), if any

Description of the changes in this PR

  • add description block to concept page twig template
  • add translations (fi, sv, en, se) needed to generate the translation
  • add cypress test to verify that it works

Known problems or uncertainties in this PR

None

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Aug 21, 2024
@osma osma self-assigned this Aug 21, 2024
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - works as expected!

@osma osma merged commit ccc76bd into main Aug 22, 2024
9 checks passed
@osma osma deleted the issue1533-seo-concept-description branch August 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants