Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EasyRdf to fix Turtle fragment URIs #1671

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

osma
Copy link
Member

@osma osma commented Aug 28, 2024

Reasons for creating this PR

We were using EasyRdf 1.7.x which is quite old and produces invalid Turtle fragment URIs in some cases, see #1591. The fix is to upgrade to easyrdf 1.10.x or newer. This PR upgrades to EasyRdf 1.13.x which is the most recent release that still works without breaking Skosmos 2 PHPUnit tests; EasyRdf 1.14.1 is currently the newest release. I don't think it makes sense to do extensive debugging of the failing Skosmos 2 unit tests, so I'm leaving the dependency at 1.13.x.

We need to drop support for PHP 7.x because EasyRdf 1.10 and above require at least PHP 8.0. This leaves only two supported PHP versions for Skosmos 2: PHP 8.0 and 8.1.

Link to relevant issue(s), if any

Description of the changes in this PR

  • upgrade to sweetrdf/easyrdf 1.13.x
  • drop PHP 7.3 and 7.4 from the GitHub Actions CI test because they're incompatible with recent EasyRdf versions
  • update README section on supported versions

Known problems or uncertainties in this PR

I didn't investigate closer why some PHPUnit tests fail when using easyrdf 1.14.x.

We need to do a similar EasyRdf upgrade for Skosmos 3 as well (main branch).

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added bug Skosmos 2.X Relevant for Skosmos 2 labels Aug 28, 2024
@osma osma added this to the 2.x milestone Aug 28, 2024
@osma osma self-assigned this Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (7a53972) to head (a9d010b).
Report is 28 commits behind head on skosmos-2.

Additional details and impacted files
@@               Coverage Diff               @@
##             skosmos-2    #1671      +/-   ##
===============================================
- Coverage        70.33%   69.65%   -0.68%     
- Complexity        1669     1784     +115     
===============================================
  Files               32       32              
  Lines             4305     4581     +276     
===============================================
+ Hits              3028     3191     +163     
- Misses            1277     1390     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osma osma merged commit 4dd3deb into skosmos-2 Aug 29, 2024
7 of 10 checks passed
@osma osma deleted the issue1591-turtle-fragment-easyrdf-upgrade-skosmos-2 branch August 29, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Skosmos 2.X Relevant for Skosmos 2
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants