Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Skosmos 2 twig syntax error on search result page #1672

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

osma
Copy link
Member

@osma osma commented Aug 30, 2024

Reasons for creating this PR

Search result pages are currently broken in Skosmos 2, after the SEO-related changes, due to a Twig template syntax bug. This PR will remove the extra endblock tag, making the search result page render properly again.

Link to relevant issue(s), if any

Description of the changes in this PR

Drop extra endblock tag.

Known problems or uncertainties in this PR

None

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added bug Skosmos 2.X Relevant for Skosmos 2 labels Aug 30, 2024
@osma osma added this to the 2.x milestone Aug 30, 2024
@osma osma self-assigned this Aug 30, 2024
Copy link

sonarcloud bot commented Aug 30, 2024

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.39%. Comparing base (a9d010b) to head (8b7d1c2).
Report is 18 commits behind head on skosmos-2.

Additional details and impacted files
@@               Coverage Diff               @@
##             skosmos-2    #1672      +/-   ##
===============================================
+ Coverage        69.65%   70.39%   +0.74%     
+ Complexity        1784     1674     -110     
===============================================
  Files               32       32              
  Lines             4581     4314     -267     
===============================================
- Hits              3191     3037     -154     
+ Misses            1390     1277     -113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma changed the title Fix Skosmos 2 twig syntax error (delete extra endblock tag) Fix Skosmos 2 twig syntax error on search result page Aug 30, 2024
@osma
Copy link
Member Author

osma commented Aug 30, 2024

This is such a trivial and obvious fix I will merge it without review.

@osma osma merged commit 33f9a4f into skosmos-2 Aug 30, 2024
8 of 10 checks passed
@osma osma deleted the fix-search-listing-template branch August 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Skosmos 2.X Relevant for Skosmos 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant