Ekirjasto 104 add accessibility headings #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natlibfi-kaisa
requested review from
natlibfi-ptalosel and
NatLibFi-JoonaKupe
NatLibFi-JoonaKupe
approved these changes
Nov 12, 2024
natlibfi-ptalosel
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This PR adds header information to where it was missing.
In addition, the lane titles and more buttons have accessibility descriptions. Also added some comments to the code.
Why are we doing this? (w/ Notion link if applicable)
Accessibility - screen readers
How should this be tested? / Do these changes have associated tests?
You can test with Accessibility Inspector: When you target header elements, they now show
Traitsvalue as heading.Have the Transifex translators been notified?
Yes