Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: add support for Angular 8 #31

Closed
christophercr opened this issue Oct 30, 2019 · 0 comments · Fixed by #34
Closed

all: add support for Angular 8 #31

christophercr opened this issue Oct 30, 2019 · 0 comments · Fixed by #34
Labels
comp: all enhancement New feature or request must
Milestone

Comments

@christophercr
Copy link
Collaborator

christophercr commented Oct 30, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/ngx-form-errors/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

NgxFormErrors is compatible only with Angular 6 and 7, however Angular 8 has been released in May 2019 and many apps are now using the latest version.

Expected behavior

NgxFormErrors should also support Angular 8 so that any app using Angular can use it. This should be straightforward since this library is really lightweight and doesn't rely on any specific Angular API that is due to change in version 8 or even 9.

What is the motivation / use case for changing the behavior?

Potentially increase the usage of this library by any Angular application.

Environment


Angular version: 8.x
@christophercr christophercr added this to the 1.0.0 milestone Oct 30, 2019
christophercr added a commit to christophercr/ngx-form-errors that referenced this issue Nov 14, 2019
SuperITMan pushed a commit to SuperITMan/ngx-form-errors that referenced this issue Feb 27, 2020
SuperITMan pushed a commit to SuperITMan/ngx-form-errors that referenced this issue Feb 27, 2020
SuperITMan pushed a commit to SuperITMan/ngx-form-errors that referenced this issue Feb 27, 2020
SuperITMan pushed a commit to SuperITMan/ngx-form-errors that referenced this issue Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: all enhancement New feature or request must
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant