Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): add 'rc' branches in .travis.yml to make Travis trigger release builds also in those #32

Conversation

christophercr
Copy link
Collaborator

@christophercr christophercr commented Nov 7, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The current configuration of Travis doesn't trigger builds if we release an RC version.

What is the new behavior?

Now the RC tags trigger Travis builds.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Also removed the nightlyVersion field that was recently added in the package.json because there are no nightly builds set up for this repo.

@christophercr christophercr added enhancement New feature or request comp: all labels Nov 7, 2019
@christophercr christophercr added this to the 1.0.0 milestone Nov 7, 2019
@christophercr christophercr changed the title Bugfix/fix travis branches fix(release): add 'rc' branches to make Travis trigger release builds also in those Nov 7, 2019
Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christophercr christophercr force-pushed the bugfix/fix-travis-branches branch from f3e5e7e to 0ebd65c Compare November 7, 2019 10:57
@christophercr christophercr changed the title fix(release): add 'rc' branches to make Travis trigger release builds also in those fix(release): add 'rc' branches in .travis.yml to make Travis trigger release builds also in those Nov 7, 2019
@christophercr christophercr merged commit a9707d5 into NationalBankBelgium:master Nov 7, 2019
@christophercr christophercr deleted the bugfix/fix-travis-branches branch November 7, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: all enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants