Modularize explore #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remiolsen
reviewed
Sep 12, 2024
remiolsen
reviewed
Sep 12, 2024
remiolsen
approved these changes
Sep 12, 2024
remiolsen
requested changes
Sep 13, 2024
remiolsen
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to split up the explore command in smaller parts. I also wanted to write tests for the explore command. I had to introduce an ugly
_run_explorecommand to enable testing on the top level.I also changed the Adaptor class since I found it confusing that the Adaptor class was initiated with an adaptors dictionary.
The name-change adaptor -> adapter will come in a later PR.