Introduce Type Descriptions Into Classes #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Type descriptions into the classes themselves. These descriptions are used when populating the 'Types' field in the Data Dictionary.
If a type does not implement TypePrettyNameSupplier (the new interface that is utilized when populating the 'Types' field), then it will use the default value provided in the interface. This is why some classes do not include these changes.
I am open to feedback based on what the values should be for
DATA_DICTIONARY_TYPE_NAME
and specifically forDEFAULT_DATA_DICTIONARY_NAME
which I assume should not be 'Default'.Related to dictionary-service/pull/31
This is the same as #33 . That PR was accidentally closed / fork was deleted.
See dictionary-service/pull/23 for more context.