Dependency analysis in gitlab #2144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
5 times, most recently
from
8d6929c to
9fec5b7
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
3 times, most recently
from
1f7ffe1 to
c215908
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
4 times, most recently
from
761736e to
367009b
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
5 times, most recently
from
c3ba32d to
83bbbc6
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
3 times, most recently
from
1a2278a to
3c84d00
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
3 times, most recently
from
f70b06f to
4545a0f
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
from
4545a0f to
56a8faa
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
4 times, most recently
from
200ea83 to
8f83b84
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
2 times, most recently
from
82a9abe to
a59bc19
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
5 times, most recently
from
ac812bd to
bdcffa7
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
from
bdcffa7 to
3b8c70c
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
5 times, most recently
from
daf2cc7 to
1952035
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
2 times, most recently
from
370ec51 to
7a481ca
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
3 times, most recently
from
292403a to
120295b
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
2 times, most recently
from
027df1d to
9c7ee8f
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
from
9c7ee8f to
d9d77bf
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
from
d9d77bf to
19f1d5c
Compare
mineralntl
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
from
12df02b to
5c98fe5
Compare
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
from
5c98fe5 to
efb5a75
Compare
alerman
previously approved these changes
Dec 13, 2024
hadoop-mapreduce-client-common
cogross
force-pushed
the
dependency-analysis-in-gitlab-squash
branch
from
efb5a75 to
7a3e64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency analysis runs in gitlab
updated structure to remove most "unused declared" and "used undeclared" dependencies.
A few still remain that are used that the tool falsely identifies as unused. Notes on those below. I tried using a few different tactics but I wasn't quite able to untangle the dependencies.
locally, run
mvn -DignoreNonCompile dependency:analyzeto see results.
NOTES
datawave-ws-atom
needs abdera, axiom-impl, axiom-api, hadoop-client-runtime
datawave-ingest-core
needs accumulo-server-base, log4j-core, hadoop-client-runtime, log4japi, log4j-slf4j-impl
datawave-ingest-csv
needs datawave-ingest-configuration, accumulo-core is not test only
datawave-ingest-json
needs datawave-ingest-configuration, hadoop-mapreducew-client-core/-common
datawave-query-core
needs json-simple, jackson-module-jaxb-annotations, lucene-analyzers-common, commons-logging, datawave-ingest-configuration, hadoop-mapreduce-client-core
datawave-ingest-wikipedia
needs datawave-ingest-configuration, type-utils not just test only
assemble-datawave
datawave-ops-tools-index-validation
needs zookeeper
OLD NOTES
datawave-core:
log4j-slf4j-implcausesorg.junit.ComparisonFailure: expected:<[Hash]UID> but was:<[Snowflake]UID>error - UID uses a logger.datawave-ws-atom:
abdera-parser,hadoop-client-runtime,axiom-api,axiom-implare all requireddatawave-ingest-core:
accumulo-server-base,log4j-core,hadoop-client-runtime,log4j-api,log4j-slf4j-implare all requireddatawave-ingest-csv:
hadoop-mapreduce-client-common,datawave-ingest-configurationare usedaccumulo-corenot just scoped for testsdatawave-ingest-json:
hadoop-mapreduce-client-core,hadoop-mapreduce-client-common,datawave-ingest-configurationare all requireddatawave-query-core:
-
hadoop-mapreduce-client-core,json-simpleare requireddatawave-ws-model:
slf4j-apiis requiredauthorization-apiis not just scoped for testsdatawave-ingest-wikipedia:
-
datawave-ingest-configurationis requiredtype-utilsis not just scoped for testsdatawave-metrics-core:
datawave-query-coreis requireddatawave-ops-tools-config-compare:
hadoop-client-runtimeis requireddatawave-ops-tools-index-validation:
zookeeper,guavaare required