Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix critical sonarqube issues #2390

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

cogross
Copy link
Collaborator

@cogross cogross commented May 15, 2024

fix up the "critical" issues found by sonarqube.
bugs and some code smells

@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from 62be21d to 5c094df Compare May 16, 2024 11:26
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 09bf83b to 482cbd0 Compare May 21, 2024 16:06
@cogross cogross requested a review from jwomeara as a code owner May 21, 2024 16:06
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 02e934d to 36b8785 Compare May 21, 2024 17:14
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 69bdac6 to 19cef4e Compare June 3, 2024 14:37
avgAGB
avgAGB previously approved these changes Jun 3, 2024
apmoriarty
apmoriarty previously approved these changes Jun 7, 2024
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 281aa8c to 6f66917 Compare June 10, 2024 15:41
@cogross cogross dismissed stale reviews from avgAGB and apmoriarty via b35c69f June 10, 2024 15:53
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 42f7890 to 3dceafe Compare July 8, 2024 15:00
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from 3dceafe to 944a2d8 Compare July 10, 2024 16:48
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from 944a2d8 to f848049 Compare July 17, 2024 19:32
@cogross cogross requested a review from ivakegg as a code owner July 17, 2024 19:32
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 43689e9 to 62f9650 Compare August 1, 2024 12:47
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from a058f3d to 60b2f51 Compare August 12, 2024 11:12
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from 60b2f51 to 195064f Compare August 20, 2024 17:04
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 5 times, most recently from 4a1af6a to 1c0c890 Compare August 29, 2024 10:49
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 4c89d21 to 7525e30 Compare September 9, 2024 19:15
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 3 times, most recently from 43f6cf7 to 937d953 Compare September 16, 2024 15:46
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from 3d249d4 to b992ffd Compare October 2, 2024 18:40
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from b992ffd to 208266a Compare October 7, 2024 18:54
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from 208266a to 1c10116 Compare October 15, 2024 16:30
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 3 times, most recently from 13e010c to 6236524 Compare November 4, 2024 11:25
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from 6236524 to 524e795 Compare November 6, 2024 18:48
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 3 times, most recently from c633884 to b98bf02 Compare November 20, 2024 11:51
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 2 times, most recently from b61f4bd to f1e2a89 Compare November 27, 2024 13:10
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch 3 times, most recently from 99f0525 to f004213 Compare December 9, 2024 14:42
@cogross cogross force-pushed the 2353-fix-critical-sonarqube-issues branch from f004213 to 55fca76 Compare December 17, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants