Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize QueryOptions to only include entries for non-default value options #2420

Open
wants to merge 60 commits into
base: integration
Choose a base branch
from
Open

Optimize QueryOptions to only include entries for non-default value options #2420

wants to merge 60 commits into from

Conversation

SethSmucker
Copy link
Collaborator

  • Create function evaluateBooleanOption() method in QueryOptions
  • Use evaluateBooleanOption() in the validateOptions() method
  • Add a test in QueryOptionsTest to test evaluateBooleanOption()

resolves #2410

@SethSmucker SethSmucker requested review from ivakegg and foster33 June 17, 2024 17:23
@SethSmucker SethSmucker requested a review from lbschanno June 25, 2024 15:50
@lbschanno lbschanno marked this pull request as draft July 9, 2024 17:43
@SethSmucker SethSmucker changed the title Add defaulting of non-"false" QueryOption fields to "true" Optimize QueryOptions to only include entries for non-default value options Jul 11, 2024
SethSmucker and others added 19 commits July 12, 2024 11:46
@SethSmucker
Merged integration into TQO
6e0d071
@SethSmucker
Merged integration into TQO
199781a
@SethSmucker @foster33
Update warehouse/query-core/src/main/java/datawave/query/iterator/Que…
bf8b43c 
…ryOptions.java

Co-authored-by: foster33 <84727868+foster33@users.noreply.github.com>
@SethSmucker
Merged integration into TQO
8b8dfd5
@SethSmucker
Formatting
ce8bd48
@SethSmucker
Fixed empty string logical error
1d4366a
@SethSmucker
Fixed empty string logical error
7860443
@lbschanno @SethSmucker
Create initial implementation of way to determin default values
e6d0edb
@lbschanno @SethSmucker
Fix typo
56c976b
@SethSmucker
Temporary commit for bugfix tools
0998782
@SethSmucker
Temporary test commit for my local branch, will be discarded later
d783669
@SethSmucker
testing changes
31dd04f
@SethSmucker
Add default values to createDefaultOptions()
1ea0d9c
@SethSmucker
Add valueTransformer type coverage in addOption()
962cca3
@SethSmucker
Add Object coverage in addOption()
3ef46f8
@SethSmucker @lbschanno
Updated the else condition of addOption()
615190e 
Co-authored-by: Laura Schanno <lbschanno@gmail.com>
@SethSmucker
Removed evaluateBooleanOptions() from validateOptions(), reverting it…
5cacfeb 
… to how it was originally
@SethSmucker
Updated DQP
6d54643
@SethSmucker
Finally rebased
1ddbcbe
@SethSmucker SethSmucker force-pushed the tighter-query-options branch from cecb5da to 1ddbcbe Compare July 12, 2024 15:58
@SethSmucker SethSmucker force-pushed the tighter-query-options branch from efd2b40 to d3c1be0 Compare August 8, 2024 18:48
@SethSmucker SethSmucker requested a review from lbschanno August 12, 2024 21:57
@ivakegg
Copy link
Collaborator

ivakegg commented Sep 4, 2024

I had added several comments but then removed them once I figured out what the thought process is here. I think this looks good, but I need to do some integration testing before bringing it in.

ivakegg
ivakegg previously approved these changes Sep 4, 2024
View reviewed changes
@ivakegg ivakegg added the MXTC label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foster33 foster33 foster33 left review comments

@lbschanno lbschanno lbschanno requested changes

@ivakegg ivakegg ivakegg left review comments

@jwomeara jwomeara Awaiting requested review from jwomeara

Requested changes must be addressed to merge this pull request.

Assignees

@SethSmucker SethSmucker

Labels
MXTC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tighter query options
4 participants
@SethSmucker @ivakegg @lbschanno @foster33