Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryFunctionsDescriptor returns all fields for multi-fielded functions #2446

Merged
merged 11 commits into from
Jul 17, 2024
Merged

QueryFunctionsDescriptor returns all fields for multi-fielded functions #2446

merged 11 commits into from
Jul 17, 2024

Conversation

apmoriarty
Copy link
Collaborator

Addresses #2445

  • added unit test for QueryFunctionsDescriptor
  • corrected bug that prevented all fields from being returned in a multi-fielded function
  • added test cases to QueryOptionsFromQueryVisitorTest

mineralntl
mineralntl previously approved these changes Jul 9, 2024
View reviewed changes
alerman
alerman previously approved these changes Jul 16, 2024
View reviewed changes
@apmoriarty apmoriarty requested a review from jwomeara as a code owner July 17, 2024 15:10
jwomeara
jwomeara reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@jwomeara jwomeara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks safe from a query microservices perspective. happy to approve from a codeowner perspective once this has 2 approvals.

@apmoriarty apmoriarty merged commit 147d616 into integration Jul 17, 2024
4 checks passed
@apmoriarty apmoriarty deleted the bugfix/query-functions-descriptor branch July 17, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivakegg ivakegg ivakegg left review comments

@hlgp hlgp hlgp approved these changes

@mineralntl mineralntl mineralntl approved these changes

@jwomeara jwomeara jwomeara approved these changes

@alerman alerman alerman left review comments

Assignees
No one assigned
Labels
Integration Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apmoriarty @alerman @ivakegg @jwomeara @mineralntl @hlgp