Update deprecated usages of SequenceFile.createWriter() #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update several deprecated calls to SequenceFile.createWriter() to use SequenceFile.createWriter(Configuration conf, SequenceFile.Writer.Option... opts) instead. Part of #2443
apmoriarty
previously approved these changes
Aug 6, 2024
avgAGB
previously approved these changes
Aug 6, 2024
ivakegg
previously approved these changes
Sep 4, 2024
ivakegg
reviewed
Nov 1, 2024
| @@ -594,7 +595,9 @@ public void close(TaskAttemptContext context) throws IOException, InterruptedExc | |||
| if (generateMapFileRowKeys && !shardMapFileRowKeys.isEmpty()) { | |||
| log.info("Writing mapFileRowKeys"); | |||
| Path shardMapFilePath = new Path(workDir, getUniqueFile(context, "mapFileRowKeys", ".lst")); | |||
| try (SequenceFile.Writer output = SequenceFile.createWriter(fs, conf, shardMapFilePath, Text.class, Text.class)) { | |||
| Path qualifiedShardMapFilePath = fs.makeQualified(shardMapFilePath); | |||
There was a problem hiding this comment.
Why call fs.makeQualified? I was looking through the deprecated code of SequenceFile.createWriter and I do not see that being called? Perhaps I missed something however.
There was a problem hiding this comment.
If I recall correctly, I believe I did it following the example of other calls to SequenceFile.createWriter(Configuration conf, Writer.Option... opts), but you're correct that it is not called in the deprecated code of SequenceFile.createWriter(). I have removed the unnecessary calls to fs.makeQualified().
lbschanno
dismissed stale reviews from avgAGB, apmoriarty, and ivakegg
via
4a47207
ivakegg
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update several deprecated calls to SequenceFile.createWriter() to use SequenceFile.createWriter(Configuration conf,
SequenceFile.Writer.Option... opts) instead.
Part of #2443