Made AbstractFilter Denylist settings configurable #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbruton
requested changes
Sep 13, 2024
fbruton
previously approved these changes
Sep 13, 2024
rupert-griffin
force-pushed
the
em-2976_Make_denylist_regexes_configurable
branch
from
4fea683
to
7e71ae4
Compare
cfkoehler
approved these changes
Sep 16, 2024
fbruton
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now configure the allowed characters in a denylist entry.
Use Regex format. e.g.
ALLOWED_NAME_CHARS = "a-zA-Z0-9_"Allowed characters will get substituted into the patterns for view name formatting and character ordering. These regexes can also be configured differently, either using
%sto substitute the allowed character string, or manually typing out the allowed chars. e.g.:VIEWNAME_FORMAT = "^[%s]+(\\.[%s]+)?\\*?$"VIEWNAME_FORMAT = "^[a-zA-Z0-9_]+(\\.[a-zA-Z0-9_]+)?\\*?$"