GP-4759 corrected BigFloat formatting of -0.0 (Closes #6677)

NationalSecurityAgency · Jul 9, 2024 · 282c6b6 · 282c6b6
1 parent 76923e1
commit 282c6b6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/pcode/floatformat/BigFloat.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/pcode/floatformat/BigFloat.java
@@ -1042,6 +1042,9 @@ private String formatSpecialCase() {
 		if (isInfinite()) {
 			return sign < 0 ? NEGATIVE_INFINITY : POSITIVE_INFINITY;
 		}
+		if (isZero()) {
+			return sign < 0 ? "-0.0" : "0.0";
+		}
 		return null;
 	}
 

diff --git a/...ra/Framework/SoftwareModeling/src/test/java/ghidra/pcode/floatformat/FloatFormatTest.java b/...ra/Framework/SoftwareModeling/src/test/java/ghidra/pcode/floatformat/FloatFormatTest.java
@@ -1480,7 +1480,11 @@ private void doTestValueOfBigInteger(BigDecimal bdVal) {
 	@Test
 	public void testValueOfBigInteger() {
 		FloatFormat ff = FloatFormatFactory.getFloatFormat(8);
-		assertEquals("0.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ZERO)));
+
+		assertFalse(ff.getBigZero(true).equals(ff.getBigZero(false)));
+
+		assertEquals("-0.0", ff.toDecimalString(ff.getBigZero(true)));
+		assertEquals("0.0", ff.toDecimalString(ff.getBigZero(false)));
 		assertEquals("1.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ONE)));
 		assertEquals("2.0", ff.toDecimalString(ff.getBigFloat(BigInteger.TWO)));
 		assertEquals("-1.0", ff.toDecimalString(ff.getBigFloat(BigInteger.ONE.negate())));