Merge remote-tracking branch 'origin/patch'

Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/function/AbstractEditFunctionSignatureDialog.java

@@ -4,9 +4,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -235,7 +235,7 @@ private void installCallingConventionWidget(JPanel parentPanel) {
 
 	private void installInlineWidget(JPanel parentPanel) {
 		inlineCheckBox = new GCheckBox("Inline");
-		inlineCheckBox.addChangeListener(e -> {
+		inlineCheckBox.addItemListener(e -> {
 			if (inlineCheckBox.isSelected() && callFixupComboBox != null) {
 				callFixupComboBox.setSelectedItem(NONE_CHOICE);
 			}

Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/references/EditMemoryReferencePanel.java

@@ -4,9 +4,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -103,7 +103,7 @@ private void buildPanel() {
 				.setAccessibleDescription(
 					"Selecting this checkbox allows entering a refernce offset");
 		offsetCheckbox.setHorizontalAlignment(SwingConstants.RIGHT);
-		offsetCheckbox.addChangeListener(e -> enableOffsetField(offsetCheckbox.isSelected()));
+		offsetCheckbox.addItemListener(e -> enableOffsetField(offsetCheckbox.isSelected()));
 		offsetField = new JTextField();
 		offsetField.getAccessibleContext().setAccessibleName("Enter Offset");
 
@@ -123,7 +123,7 @@ private void buildPanel() {
 
 		includeOtherOverlaysCheckbox = new JCheckBox("Include OTHER overlay spaces",
 			Boolean.getBoolean(Preferences.getProperty(INCLUDE_OTHER_OVERLAY_PREFERENCE, "false")));
-		includeOtherOverlaysCheckbox.addChangeListener(e -> refreshToAddressField());
+		includeOtherOverlaysCheckbox.addItemListener(e -> refreshToAddressField());
 
 		refTypes = new GhidraComboBox<>(MEM_REF_TYPES);
 		refTypes.getAccessibleContext().setAccessibleName("Memory Ref Types");

Ghidra/Features/Base/src/main/java/ghidra/app/util/AddressInput.java

@@ -4,9 +4,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -416,7 +416,7 @@ else if (comboAdded) {
 			remove(combo);
 			comboAdded = false;
 		}
-		invalidate();
+		revalidate();
 	}
 
 	@Override

Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/provider/matchtable/ApplyMarkupPropertyEditor.java

@@ -4,9 +4,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -838,7 +838,7 @@ private JComboBox<Enum<?>> createComboBox(final String optionName, final Enum<?>
 
 	private JCheckBox createCheckBox(String optionName) {
 		JCheckBox applyCheckBox = new GCheckBox(optionName);
-		applyCheckBox.addChangeListener(e -> changesMade(true));
+		applyCheckBox.addItemListener(e -> changesMade(true));
 
 		return applyCheckBox;
 	}

Ghidra/Framework/Docking/src/main/java/docking/widgets/conditiontestpanel/ConditionTestPanel.java

@@ -4,9 +4,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -376,7 +376,7 @@ public TestPanel(ConditionTester conditionTest) {
 			label = new GDLabel(test.getName());
 			add(label);
 			label.setToolTipText(test.getDescription());
-			checkbox.addChangeListener(e -> {
+			checkbox.addItemListener(e -> {
 				conditionTestModel.setEnabled(test, checkbox.isSelected());
 				label.setEnabled(checkbox.isSelected());
 			});