Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompiler: Add printRaw implementation for ambiguous TypeOps #5063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukeSerne
Copy link
Contributor

Fixes #4951.

This adds a printRaw implementation to 13 TypeOps, similar in implementation to TypeOpIntSright::printRaw. This change makes it possible to uniquely identify the TypeOp that produced a given printRaw output. The new operators used also correspond to the sleigh syntax for the TypeOps. The changed operators are also shown in the table below.

TypeOp class name Old operator New operator
TypeOpIntSless < s<
TypeOpIntSlessEqual <= s<=
TypeOpIntSdiv / s/
TypeOpIntSrem % s%
TypeOpFloatEqual == f==
TypeOpFloatNotEqual != f!=
TypeOpFloatLess < f<
TypeOpFloatLessEqual <= f<=
TypeOpFloatAdd + f+
TypeOpFloatDiv / f/
TypeOpFloatMult * f*
TypeOpFloatSub - f-
TypeOpFloatNeg (unary) - f-

This adds a `printRaw` implementation to 13 TypeOps, similar in implementation
to `TypeOpIntSright::printRaw`.
@LukeSerne
Copy link
Contributor Author

What's the progress on this PR? It's been in triage for quite some time now. Is there anything I can do to help this get merged?

@ryanmkurtz
Copy link
Collaborator

It likely hasn't been looked at yet. Theoretically it will be one day though when @caheckman's queue thins out.

@LukeSerne
Copy link
Contributor Author

Thanks for the response. I am probably a bit biased, but I think this PR shouldn't be too much effort to review and it might be an easy one to decrease the number of open PRs. On the other hand, looking at all the issues and pull requests assigned to @caheckman, I understand this PR is not at the top of that list.

If there's anything I can do to help this PR or any of my other PRs / issues, feel free to let me know. It can be quite frustrating to see it's been assigned and it sitting in triage for months with no comment from the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Decompiler Status: Triage Information is being gathered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decompiler: PCode representation produced by TypeOp::printRaw is ambiguous
4 participants