Decompiler: RuleIgnoreNan: Don't descend if NAN flow has been removed
#6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, when `RuleIgnoreNan` tries to remove NaN-branches from conditionals, it is too aggressive and also removes other branches, leading to incorrect decompiler output. By returning a null pointer if the NAN flow has been removed by replacing the boolean combinator such as `BOOL_AND` or `BOOL_OR` by a `COPY` operation, we avoid descending down further and removing too much of the tree.
ryanmkurtz
added
Feature: Decompiler
Status: Triage
ryanmkurtz
added
Status: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when
RuleIgnoreNantries to removeNAN-branches from conditionals, it is too aggressive and also removes other branches, leading to incorrect decompiler output. By returning a null pointer if theNANflow has been removed by replacing the boolean operation such asBOOL_ANDorBOOL_ORby aCOPYoperation, we avoid descending down further and removing too much of the tree.Fixes #6580