Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using HMR with a modal view breaks livesync #7668

Closed
VladimirAmiorkov opened this issue Aug 9, 2019 · 1 comment
Closed

Using HMR with a modal view breaks livesync #7668

VladimirAmiorkov opened this issue Aug 9, 2019 · 1 comment
Assignees
@VladimirAmiorkov
Labels
bug livesync modal-page

Comments

@VladimirAmiorkov
Copy link
Contributor

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.0.3
  • Cross-platform modules: 6.0.6
  • Android Runtime: 6.0.1
  • iOS Runtime: 6.0.2

Describe the bug
Similar to this issue but calling the close callback still works. The issue is that the modal's content is not changed accordingly to the changes and is not closed.

To Reproduce

  • Open any modal view
  • Make changes to that modal views xml
  • Save the changes and wait for hmr to livesync the changes

Expected behavior
The modal view is closed during hmr
@VladimirAmiorkov VladimirAmiorkov self-assigned this Aug 9, 2019
@VladimirAmiorkov VladimirAmiorkov mentioned this issue Aug 9, 2019
Closed
5 tasks
VladimirAmiorkov pushed a commit that referenced this issue Aug 9, 2019
fix(hmr): close modal views during livesync #7668
ae9ecff
VladimirAmiorkov pushed a commit that referenced this issue Aug 14, 2019
fix(hmr): close modal views during livesync #7668
91f3bd1 
chore: add unit tests to test that modal views are closed during hmr
@VladimirAmiorkov VladimirAmiorkov mentioned this issue Aug 14, 2019
Merged
5 tasks
VladimirAmiorkov pushed a commit that referenced this issue Aug 15, 2019
fix(hmr): close modal views during livesync #7668 (#7679)
9877b20 
chore: add unit tests to test that modal views are closed during hmr
@zbranzov
Copy link

The fix is released in nativescript-angular@8.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladimirAmiorkov VladimirAmiorkov

Labels
bug livesync modal-page
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zbranzov @VladimirAmiorkov @NickIliev