fix(6913): set/unset touchListener.owner onLoaded/onUnloaded

[m-abs]

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
• Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is the current behavior?

The TouchListener added to View on android have a owner-reference that is never cleared like it is on other native classes like the clickListener in button.android.ts.
So the TouchListener and View will keep pointing to each other as seen in #6913.

What is the new behavior?

Like on clickListener in button.android.ts owner is bound to the touchListener when onLoaded is called and removed again when onUnloaded is called.

Fixes #6913

[m-abs]

The one of the existing tests failed with:

JS: Test: --- [UTILS.test_releaseNativeObject_canBeCalledWithNativeObject] FAILED: __releaseNativeCounterpart is not defined, Stack: ReferenceError: __releaseNativeCounterpart is not defined

I don't think I caused it, but cannot check the "All existing tests are passing:"-box.

[vakrilov]

I would suggest to just use a WeakRef for the owner so that we don't have to worry about when and if we should clear it up. We do this in many other cases when there is a Listener or Handler object that is just used for a native callback (like here)

[m-abs]

Hi @vakrilov

That was something I wondered when I reported the issue.

On iOS tns-core-modules uses a WeakRef for the owner references, but most cases I've seen for Android don't use a WeakRef for the same.
Like here:

NativeScript/tns-core-modules/ui/action-bar/action-bar.android.ts

Line 145 in 23147ae

const menuItemClickListener = new MenuItemClickListener(this);

NativeScript/tns-core-modules/ui/action-bar/action-bar.android.ts

Lines 39 to 53 in 23147ae

	class MenuItemClickListenerImpl extends java.lang.Object implements android.support.v7.widget.Toolbar.OnMenuItemClickListener {
	constructor(public owner: ActionBar) {
	super();
	return global.__native(this);
	}
	onMenuItemClick(item: android.view.MenuItem): boolean {
	let itemId = item.getItemId();
	return this.owner._onAndroidItemSelected(itemId);
	}
	}
	MenuItemClickListener = MenuItemClickListenerImpl;
	appResources = application.android.context.getResources();
	}

That was why I choose not to use one.

I'll update my PR as requested.

[vakrilov]

test

[manoldonev]

test

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.