fix(android/TextField): set focusable, clickable to false if not editable #8525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble is false Do not clear key listener when editable is false This prevents the input type to be changed. Instead, we can set focusable, clickable to false. This allows to change input Type i.e (secure) at run time when editable is false. Reference issue: NativeScript#8523
vtrifonov
changed the title
vtrifonov
approved these changes
Apr 14, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
…ble is false (#8525) Do not clear key listener when editable is false This prevents the input type to be changed. Instead, we can set focusable, clickable to false. This allows to change input Type i.e (secure) at run time when editable is false. Reference issue: #8523 Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
…ble is false (#8525) Do not clear key listener when editable is false This prevents the input type to be changed. Instead, we can set focusable, clickable to false. This allows to change input Type i.e (secure) at run time when editable is false. Reference issue: #8523 Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not clear key listener when editable is false This prevents the input type to be changed.
Instead, we can set focusable, clickable to false.
This allows to change input Type i.e (secure) at run time when editable is false.
Reference issue: #8523
PR Checklist
What is the current behavior?
In android platform, In TextField if editable is set to false. We cannot change or toggle secure property. This occurs because we are setting KeyListener to false. Instead we can set Focusable, clickable to false.
What is the new behavior?
Now, one can toggle between secure property, even if editable is set to false.