Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No requests are shown in Network tab with tns debug ios --bundle #1057

Closed
Natalia-Hristova opened this issue Jan 11, 2019 · 0 comments
Closed

No requests are shown in Network tab with tns debug ios --bundle #1057

Natalia-Hristova opened this issue Jan 11, 2019 · 0 comments
Assignees
@mbektchiev @Natalia-Hristova
Milestone
5.3.0

Comments

@Natalia-Hristova
Copy link
Contributor

Natalia-Hristova commented Jan 11, 2019 •
edited
Loading

Environment

  • CLI: rc -> 5.1.1-2019-01-11-12787
  • iOS Runtime: rc -> 5.1.0-rc-2019-01-07-175720-02 or official: 5.1.0

Describe the bug
Network requests are not shown when use tns debug ios --bundle
NOTE: also not shown when tns debug ios --inspector --bundle

To Reproduce

  1. Create a js project that use webpack and has network requests
  2. Run tns debug ios --bundle or tns debug ios --inspector --bundle
  3. Open the url in Chrome
  4. Go to Network tab

Expected behavior
Network requests to be shown in the Network tab

Sample project

Additional context
mbektchiev added a commit that referenced this issue Feb 12, 2019
@mbektchiev
fix(inspector): Catch and log inspector_modules.js loading errors
91542bd 
`inspector_modules.js` is loaded whenever a new debugger connection is established.
When the application is built with `--bundle` however, the file is missing and debugging
is not working correctly. Log the rejection reason to the console so that errors with it don't
silently remain undetected in the future.

related to #1054, #1055, #1056, #1057
@mbektchiev mbektchiev mentioned this issue Feb 12, 2019
Merged
5 tasks
mbektchiev added a commit to NativeScript/nativescript-dev-webpack that referenced this issue Feb 12, 2019
@mbektchiev
fix: Emit inspector_modules.js as a separate entry point for iOS
22c68fe 
ios-runtime calls it explicitly by name and it has to be emitted in `tns_modules/tns_core_modules`

Fix NativeScript/ios-jsc#1054, NativeScript/ios-jsc#1055
NativeScript/ios-jsc#1056, NativeScript/ios-jsc#1057
mbektchiev added a commit to NativeScript/nativescript-dev-webpack that referenced this issue Feb 12, 2019
@mbektchiev
fix: Emit inspector_modules.js as a separate entry point for iOS
495b836 
The iOS Runtime calls it explicitly by name and it has to be emitted
in `tns_modules/tns_core_modules`

Refs: NativeScript/ios-jsc#1054, NativeScript/ios-jsc#1055
NativeScript/ios-jsc#1056, NativeScript/ios-jsc#1057
@mbektchiev mbektchiev mentioned this issue Feb 12, 2019
Merged
5 tasks
@mbektchiev mbektchiev self-assigned this Feb 13, 2019
@mbektchiev mbektchiev added this to the 5.3.0 milestone Feb 13, 2019
mbektchiev added a commit to NativeScript/nativescript-dev-webpack that referenced this issue Feb 13, 2019
@mbektchiev
fix: Emit inspector_modules.js as a separate entry point for iOS
00ecaa0 
The iOS Runtime calls it explicitly by name and it has to be emitted
in `tns_modules/tns_core_modules`

Refs: NativeScript/ios-jsc#1054, NativeScript/ios-jsc#1055
NativeScript/ios-jsc#1056, NativeScript/ios-jsc#1057
mbektchiev added a commit to NativeScript/NativeScript that referenced this issue Feb 14, 2019
@mbektchiev
fix(debugger): Enable iOS inspector modules on creation
502e471 
When the application is being debugged with `--debug-brk --bundle`
options, the JS implementation objects handling the debugging protocol
are created after their corresponding domains' `enable` methods have
been called by the debugger frontend. As a workaround we now manually
call `enable` in their constructors.

related to NativeScript/ios-jsc#1055 and
NativeScript/ios-jsc#1057
@mbektchiev mbektchiev mentioned this issue Feb 14, 2019
Merged
5 tasks
mbektchiev added a commit to NativeScript/NativeScript that referenced this issue Feb 15, 2019
@mbektchiev
fix(debugger): Enable iOS inspector modules on creation
1b5d307 
When the application is being debugged with `--debug-brk --bundle`
options, the JS implementation objects handling the debugging protocol
are created after their corresponding domains' `enable` methods have
been called by the debugger frontend. As a workaround we now manually
call `enable` in their constructors.

related to NativeScript/ios-jsc#1055 and
NativeScript/ios-jsc#1057
vchimev pushed a commit to NativeScript/nativescript-dev-webpack that referenced this issue Feb 19, 2019
@mbektchiev @vchimev
fix: Emit inspector_modules.js as a separate entry point for iOS
5c79f1c 
The iOS Runtime calls it explicitly by name and it has to be emitted
in `tns_modules/tns_core_modules`

Refs: NativeScript/ios-jsc#1054, NativeScript/ios-jsc#1055
NativeScript/ios-jsc#1056, NativeScript/ios-jsc#1057
@Natalia-Hristova Natalia-Hristova self-assigned this Mar 7, 2019
@mbektchiev mbektchiev changed the title No requests are shown in Network tab when use tns debug ios --bundle No requests are shown in Network tab with tns debug ios --bundle Mar 22, 2019
@ghost ghost removed the ready for release label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbektchiev mbektchiev

@Natalia-Hristova Natalia-Hristova

Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

No branches or pull requests
2 participants
@mbektchiev @Natalia-Hristova