Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata-generator): Improve blacklist/whitelist filtering diagnostics #1247

Merged
merged 2 commits into from
Jan 25, 2020

Conversation

mbektchiev
Copy link
Contributor

  • In verbose logs include both the JS and Native names if different

  • Output which rule enabled and which rule disabled a given entity
    in verbose logs. This makes it much easier to understand why
    a particular symbol is considered blacklisted or whitelisted.

  • Output command line arguments in stderr stream along with stdout
    and remove the additional quotes and commas. This way it's much easier
    to grab all arguments directly from the stderr text file and paste them in
    Xcode to debug metadata generation.

  • Rename the --no-apply-manual-changes argument to
    -apply-manual-dts-changes (defaulting to true). This name better
    conveys its purpose, uses LLVM argument parsing (like all other
    arguments) and doesn't start with a negation. Passing
    -apply-manual-dts-changes=false disables the default.

PR Checklist

refs #1209

…stics

* In verbose logs include both the JS and Native names if different

* Output which rule enabled and which rule disabled a given entity
in verbose logs. This makes it much easier to understand why
a particular symbol is considered blacklisted or whitelisted.

* Output command line arguments in `stderr` stream along with `stdout`
and remove the additional quotes and commas. This way it's much easier
to grab all arguments directly from the `stderr` text file and paste them in
Xcode to debug metadata generation.

* Rename the `--no-apply-manual-changes` argument to
`-apply-manual-dts-changes` (defaulting to `true`). This name better
conveys its purpose, uses LLVM argument parsing (like all other
arguments) and doesn't start with a negation. Passing
`-apply-manual-dts-changes=false` disables the default.
@mbektchiev mbektchiev added this to the 6.4.0 milestone Jan 24, 2020
@mbektchiev mbektchiev self-assigned this Jan 24, 2020
@cla-bot cla-bot bot added the cla: yes label Jan 24, 2020
Update expected test results from Xcode 11.0 to 11.3.1
@mbektchiev mbektchiev merged commit b9c51e7 into master Jan 25, 2020
@mbektchiev mbektchiev deleted the bektchiev/filter-metadata branch January 25, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants