fix(detached-loader): detach loadWithFactory (#2260)

NativeScript · Sep 21, 2020 · 1dca81b · 1dca81b
1 parent bcde284
commit 1dca81b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/nativescript-angular/common/detached-loader.ts b/nativescript-angular/common/detached-loader.ts
@@ -49,6 +49,13 @@ export class DetachedLoader implements OnDestroy {
 	}
 
 	public loadWithFactory<T>(factory: ComponentFactory<T>): ComponentRef<T> {
-		return this.containerRef.createComponent(factory, this.containerRef.length, this.containerRef.injector, null);
+		const componentRef = factory.create(this.containerRef.injector);
+		this.appRef.attachView(componentRef.hostView);
+
+		this.disposeFunctions.push(() => {
+			this.appRef.detachView(componentRef.hostView);
+			componentRef.destroy();
+		});
+		return componentRef;
 	}
 }