feat: add svelte support #170
Conversation
| .DS_Store | ||
|
|
||
| *.js.map | ||
| *.js |
There was a problem hiding this comment.
Not sure about including *.js here.
The current svelte template doesn't have it, and neither does the vue one https://github.com/NativeScript/nativescript-app-templates/blob/master/packages/template-blank-vue/.gitignore
There was a problem hiding this comment.
I just noticed that this may have bitten us already. The .gitignore file ignores svelte.config.js which is assumed to exist by the webpack plugin https://github.com/NativeScript/NativeScript/pull/8963/files#diff-34201858e4b5b4e6eaad695e47ee0ec6b6ae4b60ccc81bab535438a0520895e8R15
There was a problem hiding this comment.
@halfnelson this gitignore is actually for the templates repo - the one that's used/ends up in projects is from packages/template-blank-svelte/tools/dot.gitignore - so I guess both need to change!
| .DS_Store | ||
|
|
||
| *.js.map | ||
| *.js |
There was a problem hiding this comment.
It might be safer to remove the *.js here. I have been bitten before by this excluding other config files
There was a problem hiding this comment.
👍 - would ideally refactor all to use files in package.json rather than npmignore
| Execute the following command to create an app from this template: | ||
|
|
||
| ``` | ||
| ns create my-blank-svelte --template @nativescript/template-blank-svelte |
There was a problem hiding this comment.
if NativeScript/nativescript-cli#5418 is merged, will this become ns create my-blank-svelte --svelte
There was a problem hiding this comment.
Ah, nevermind this is the docs for the template itself
|
Apart from the .gitignore thing and missing svelte.config.js the rest looks great |
|
|
||
| # NativeScript Template | ||
| *.js.map | ||
| *.js |
There was a problem hiding this comment.
@halfnelson I believe this should suffice for the config being ignored?
| .DS_Store | ||
|
|
||
| *.js.map | ||
| *.js |
Depends on:
NativeScript/NativeScript#8963
NativeScript/nativescript-cli#5418
PR Checklist
What is the current behavior?
N/A
What is the new behavior?
Added svelte support
Fixes/Implements/Closes #[Issue Number].