Merge pull request #1219 from NativeScript/fatme/show-app-output-by-l…

…ivesync-command Show application output from livesync command
NativeScript · Nov 20, 2015 · 980ee5e · 980ee5e
2 parents 441f927 + d81817a
commit 980ee5e
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 9 deletions.
diff --git a/lib/commands/livesync.ts b/lib/commands/livesync.ts
@@ -9,7 +9,6 @@ export class LivesyncCommand implements ICommand {
 		private $errors: IErrors) { }
 
 	public execute(args: string[]): IFuture<void> {
-		this.$options.justlaunch = true;
 		return this.$usbLiveSyncService.liveSync(args[0]);
 	}
 

diff --git a/lib/common b/lib/common
diff --git a/lib/providers/device-log-provider.ts b/lib/providers/device-log-provider.ts
@@ -2,10 +2,38 @@
 "use strict";
 
 export class DeviceLogProvider implements Mobile.IDeviceLogProvider {
-	constructor(private $logger: ILogger) { }
+	//sample line is "I/Web Console(    4438): Received Event: deviceready at file:///storage/emulated/0/Icenium/com.telerik.TestApp/js/index.js:48"
+	private static LINE_REGEX = /.\/(.+?)\s*\(\s*(\d+?)\): (.*)/;
 
-	public logData(line: string, platform: string, deviceIdentifier: string): void {
-		this.$logger.out(line);
+	constructor(private $devicePlatformsConstants: Mobile.IDevicePlatformsConstants,
+		private $logger: ILogger) { }
+
+	public logData(lineText: string, platform: string, deviceIdentifier: string): void {
+		if (!platform || platform.toLowerCase() === this.$devicePlatformsConstants.iOS.toLowerCase()) {
+			this.$logger.out(lineText);
+		} else if (platform === this.$devicePlatformsConstants.Android) {
+			let log = this.getConsoleLogFromLine(lineText);
+			if (log) {
+				if (log.tag) {
+					this.$logger.out(`${log.tag}: ${log.message}`);
+				} else {
+					this.$logger.out(log.message);
+				}
+			}
+		}
+	}
+
+	private getConsoleLogFromLine(lineText: String): any {
+		let acceptedTags = ["chromium", "Web Console", "JS"];
+		let match = lineText.match(DeviceLogProvider.LINE_REGEX);
+		if (match) {
+			if(acceptedTags.indexOf(match[1]) !== -1) {
+				return {tag: match[1], message: match[3]};
+			}
+		} else if (_.any(acceptedTags, (tag: string) => { return lineText.indexOf(tag) !== -1; })) {
+			return {message: match[3]};
+		}
+		return null;
 	}
 }
 $injector.register("deviceLogProvider", DeviceLogProvider);
diff --git a/lib/services/platform-service.ts b/lib/services/platform-service.ts
@@ -353,10 +353,6 @@ export class PlatformService implements IPlatformService {
 				return (() => {
 					platformData.platformProjectService.deploy(device.deviceInfo.identifier).wait();
 					device.deploy(packageFile, this.$projectData.projectId).wait();
-
-					if (!this.$options.justlaunch) {
-						device.openDeviceLogStream();
-					}
 				}).future<void>()();
 			};
 			this.$devicesService.execute(action).wait();