Skip to content

Commit

Permalink
feat(doctor): add android-33 to supported sdks
Browse files Browse the repository at this point in the history
rigor789 committed Jul 25, 2022

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
1 parent 1da28bc commit b8f15a0
Showing 2 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/doctor/src/android-tools-info.ts
Original file line number Diff line number Diff line change
@@ -29,6 +29,7 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
"android-30",
"android-31",
"android-32",
"android-33",
];

const isRuntimeVersionLessThan = (targetVersion: string) => {
9 changes: 6 additions & 3 deletions packages/doctor/test/android-tools-info.ts
Original file line number Diff line number Diff line change
@@ -55,6 +55,7 @@ describe("androidToolsInfo", () => {
"30.0.0",
"31.0.0",
"32.0.0",
"33.0.0",
];
} else {
return [
@@ -65,6 +66,7 @@ describe("androidToolsInfo", () => {
"android-30",
"android-31",
"android-32",
"android-33",
];
}
},
@@ -100,7 +102,7 @@ describe("androidToolsInfo", () => {
const androidToolsInfo = getAndroidToolsInfo("8.2.0");
const toolsInfo = androidToolsInfo.getToolsInfo({ projectDir: "test" });

assert.equal(toolsInfo.compileSdkVersion, 32);
assert.equal(toolsInfo.compileSdkVersion, 33);
});
});

@@ -132,10 +134,11 @@ describe("androidToolsInfo", () => {
assertSupportedRange("8.1.0", min, max);
});

it("runtime 8.2.0 should support android-17 - android-32", () => {
it("runtime 8.2.0 should support android-17 - android-33", () => {
const min = 17;
const max = 32;
const max = 33;
assertSupportedRange("8.2.0", min, max);
assertSupportedRange("8.3.0", min, max);
});
});

0 comments on commit b8f15a0

Please sign in to comment.