fix: runtime versions with a range

NativeScript · Sep 10, 2021 · e0bbf1b · e0bbf1b
1 parent 58a0e60
commit e0bbf1b
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/lib/services/project-data-service.ts b/lib/services/project-data-service.ts
@@ -33,6 +33,7 @@ import { IDictionary, IFileSystem, IProjectDir } from "../common/declarations";
 import * as _ from "lodash";
 import { IInjector } from "../common/definitions/yok";
 import { injector } from "../common/yok";
+import * as semver from "semver";
 
 interface IProjectFileData {
 	projectData: any;
@@ -615,9 +616,12 @@ export class ProjectDataService implements IProjectDataService {
 			});
 
 		if (runtimePackage) {
-			// in case we are using a local tgz for the runtime
-			//
-			if (runtimePackage.version.includes("tgz")) {
+			const isRange =
+				semver.coerce(runtimePackage.version).version !==
+				runtimePackage.version;
+
+			// in case we are using a local tgz for the runtime or a range like ~8.0.0, ^8.0.0 etc.
+			if (runtimePackage.version.includes("tgz") || isRange) {
 				try {
 					const runtimePackageJsonPath = require.resolve(
 						`${runtimePackage.name}/package.json`,
@@ -629,7 +633,15 @@ export class ProjectDataService implements IProjectDataService {
 						runtimePackageJsonPath
 					).version;
 				} catch (err) {
-					runtimePackage.version = null;
+					if (isRange) {
+						runtimePackage.version = semver.coerce(
+							runtimePackage.version
+						).version;
+
+						(runtimePackage as any)._coerced = true;
+					} else {
+						runtimePackage.version = null;
+					}
 				}
 			}