Skip to content

Commit

Permalink
fix: launching android 11 and 12 emulators
Browse files Browse the repository at this point in the history
  • Loading branch information
rigor789 committed Sep 12, 2021
1 parent 4f8d644 commit f32642e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/commands/migrate.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { IProjectData } from "../definitions/project";
import { IMigrateController } from "../definitions/migrate";
import { IMigrateController, IMigrationData } from "../definitions/migrate";
import { ICommand, ICommandParameter } from "../common/definitions/commands";
import { injector } from "../common/yok";

Expand All @@ -17,7 +17,7 @@ export class MigrateCommand implements ICommand {
}

public async execute(args: string[]): Promise<void> {
const migrationData = {
const migrationData: IMigrationData = {
projectDir: this.$projectData.projectDir,
platforms: [
this.$devicePlatformsConstants.Android,
Expand Down
2 changes: 2 additions & 0 deletions lib/common/mobile/emulator-helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { injector } from "../yok";
export class EmulatorHelper implements Mobile.IEmulatorHelper {
// https://developer.android.com/guide/topics/manifest/uses-sdk-element
public mapAndroidApiLevelToVersion = {
"android-31": "12.0.0",
"android-30": "11.0.0",
"android-29": "10.0.0",
"android-28": "9.0.0",
"android-27": "8.1.0",
Expand Down
2 changes: 1 addition & 1 deletion lib/controllers/migrate-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ export class MigrateController
shouldMigrate = await this._shouldMigrate({
projectDir,
platforms: remainingPlatforms,
loose: loose,
loose,
});
this.$logger.trace(
`Executed shouldMigrate for platforms: ${remainingPlatforms}. Result is: ${shouldMigrate}`
Expand Down

0 comments on commit f32642e

Please sign in to comment.