Build continues after gradle build fails #2639
Comments
|
Thsi will be fixed with this PR: #2630 |
|
I believe this happened when I'm using Brief of output: |
|
Im on 3, getting this now. Only fix seems to be platform remove\add. If I do a tns run android it's fine, but if I then do a tns build android this error happens. |
|
@sitefinitysteve Is it the error that happens, or does the application indeed fire up on the device, despite the fact that the build failed? |
|
Well tns run android works, app fires up. But then immediately after i can
do tns build Android and get this.
I kept deploying an apk and want seeing the changes i had in the app or
sim, so i tried to build explicitly.
On Jun 18, 2017 2:55 PM, "Peter Kanev" <notifications@github.com> wrote:
@sitefinitysteve <https://github.com/sitefinitysteve> Is it the error that
happens, or does the application indeed fire up on the device, despite the
fact that the build failed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2639 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABeI6B42H77aHIOJiGFPDa4jzWw7DUg4ks5sFXKtgaJpZM4MmfCz>
.
|
|
@sitefinitysteve please refer to NativeScript/android#778 (comment) for the error you are seeing. Also the cause for the error will be less aggressive in 3.1 and print out the classes responsible. If you see that in uglify-webpacked apps - it is likely you have some extended native classes that have not been excluded from the class name mangling. |
|
Hmm okay great, not webpacked btw.
We talking like .xml/js names the same? I do have like
Folder1\comment.xml
Folder2\comment.xml
Is this what you're talking about?
…On Jun 18, 2017 3:03 PM, "Peter Kanev" ***@***.***> wrote:
@sitefinitysteve <https://github.com/sitefinitysteve> please refer to
NativeScript/android#778 (comment)
<NativeScript/android#778 (comment)>
for the error you are seeing. Also the cause for the error will be less
aggressive in 3.1 and print out the classes responsible. If you see that in
uglify-webpacked apps - it is likely you have some extended native classes
that have not been excluded from the class name mangling.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2639 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABeI6DIrozZ-YwthHp_80FZGM77T3sJoks5sFXSYgaJpZM4MmfCz>
.
|
Problem:
If the gradle build fails, the CLI will continue executing, printing
Project successfully built. Installing..., and will attempt to adb push an APK.What this means is that if there is an APK available and a consecutive build fails, the older APK will be used, and the user may never learn that their build didn't complete successfully.
Versions:
Steps to reproduce:
tns create crashMecd crashMetns platform add android@nexttns build/run androidtns plugin remove tns-core-modulestns plugin add tns-core-modules@internal-previewtns run androidOR
make changes to the 'build.gradle' in a task's execution phase to force an exceptiontns run androidThe run will output the following:
It becomes evident that the gradle build failed during asbg:generateBindings, and the output of the process is 'BUILD FAILED'. Despite that the build continues and deploys on device (provided there was an APK available previously)
The text was updated successfully, but these errors were encountered: