Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LiveSync to iOS Wi-Fi devices #4966

Closed
11 tasks done
DimitarTachev opened this issue Aug 23, 2019 · 0 comments
Closed
11 tasks done

Support LiveSync to iOS Wi-Fi devices #4966

DimitarTachev opened this issue Aug 23, 2019 · 0 comments
Assignees
@DimitarTachev
Labels
feature
Milestone
6.1.0

Comments

@DimitarTachev
Copy link
Contributor

DimitarTachev commented Aug 23, 2019 •
edited by miroslavaivanova
Loading

Is your feature request related to a problem? Please describe.
Take a look at the related issue.

Additional context
The Debugging will be handled in another feature as connecting to the Debug Socket of Wi-Fi connected device is not so easy (we are currently using USBMuxConnectByPort which requires USB connections).

Acceptance Criteria

  • when a device is discoverable in iTunes, it should be also visible in tns devices.
  • the WiFi connected devices should be shown with Connection Type: Wifi in the devices list.
  • the WiFi connected devices which are also wired with USB cable should be shown with Connection Type: USB, Wifi in the devices list.
  • the Simulators should be shown with Connection Type: Local in the devices list.
  • tns debug ios should show a meaningful error message when the device is connected only through Wi-Fi.
  • tns run ios and the Hot Updates should be working properly even when the device is connected only through Wi-Fi. It should also work as expected when we restart the device and re-run the command without USB cable.
  • tns test should also work as expected with Wi-Fi only devices.
  • each hot updated should take the same amount of time (both with USB and Wi-Fi)
  • the NativeScript Debugger Attached log should not be printed during tns run and Hot Updates anymore.
  • the LiveSync should stop working only when both of the USB and Wi-Fi connections are lost.
  • we should be able to run on Windows with both Wi-Fi and USB iOS devices (through SideKick).

Related to: #4252
@DimitarTachev DimitarTachev added this to the 6.1.0 milestone Aug 23, 2019
@DimitarTachev DimitarTachev self-assigned this Aug 23, 2019
@DimitarTachev DimitarTachev mentioned this issue Aug 23, 2019
Merged
5 tasks
Fatme added a commit to NativeScript/ios-jsc that referenced this issue Aug 27, 2019
@Fatme
fix: notify for AppRefreshStarted and remove the log for successful r…
66bc74f 
…efresh request

Currently CLI performs an additional application start when sending refresh notification to the application. The purpose of this additional application start is to ensure that the application will be started when sending the notification no matter if it is currently crashed. However, this additional operation slows down the entire livesync process with around 2-3 seconds per change. The purpose of this PR is to eliminate the delay as posting `AppRefreshStarted` notification from application. CLI starts an observer notification in order to check if the `AppRefreshStarted` will be sent from the application. In case it is sent, CLI refreshes the application via `RefreshRequest` notification. In case a such notification is not sent, CLI restarts the application in 3 seconds (this is the timeout for awaiting the notification from application).

Rel to NativeScript/nativescript-cli#4966
This was referenced Aug 27, 2019
Merged
Merged
Fatme added a commit that referenced this issue Sep 2, 2019
@Fatme
fix: force refresh with socket when debugging the application
7f60833 
Currently there is an issue when livesyncing the application when it is stopped on breakpoint. The problem is that the application is always restarted - most probably due to issue with "RefreshRequest" notification. However, this notification was added as we needed to support syncing on wifi devices. As debug command doesn't work with wifi devices, we'll force refresh with socket on debug command.

Rel to: #4966
Fatme added a commit that referenced this issue Sep 2, 2019
@Fatme
fix: force refresh with socket when debugging the application
02216b0 
Currently there is an issue when livesyncing the application when it is stopped on breakpoint. The problem is that the application is always restarted - most probably due to issue with "RefreshRequest" notification. However, this notification was added as we needed to support syncing on wifi devices. As debug command doesn't work with wifi devices, we'll force refresh with socket on debug command.

Rel to: #4966
@Fatme Fatme mentioned this issue Sep 2, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitarTachev DimitarTachev

Labels
feature
Projects
None yet
Milestone
6.1.0
Development

No branches or pull requests
2 participants
@DimitarTachev @miroslavaivanova