Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extensions): add extension podfile and setup extension with provision #5751

Merged

Conversation

miladfm
Copy link
Contributor

@miladfm miladfm commented Aug 4, 2023

This PR fixes the following open issue
#5520
#5244

PR Checklist

What is the current behavior?

  • Currently, the NativeScript CLI does not support Podfiles for extensions. The final Podfile is wrapped with the main application target. However, extensions require their own unique targets.

  • Additionally, it is currently not possible to build the iOS app with an extension and a provided team ID or provision.

What is the new behavior?

  • With this update, developers can now create a Podfile in each extension folder, similar to how they would for the main app. During the build process, the CLI will generate a new target with the extension name and merge it with the existing final Podfile. As a result, the Podfile, after the build, will contain plugins, App-Resources, and extension Podfiles.

  • Extension signing will inherit the signing style and team ID from the main app. If the build command contains the provision, the extension will also be signed with the provided provisions from the provisioning.json file located in the extension folder.

…ision

feat(extensions): allow multi podfile for different targets

refactor(extensions): refactor extension podfile

style: fix style syntax
@cla-bot
Copy link

cla-bot bot commented Aug 4, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @miladfm.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@miladfm
Copy link
Contributor Author

miladfm commented Aug 4, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Aug 4, 2023
@cla-bot
Copy link

cla-bot bot commented Aug 4, 2023

The cla-bot has been summoned, and re-checked this pull request!

@rigor789 rigor789 self-requested a review August 4, 2023 14:58
@NathanWalker
Copy link
Contributor

Nice work @miladfm! We have also been working around extensions lately so great timing 👍

@miladfm
Copy link
Contributor Author

miladfm commented Aug 4, 2023

Thank you @NathanWalker :)

In our project, we're adding a new feature - a notification service to decrypt messages. To support this, I made some changes to the source code which we have tested in TestFlight and the App Store.

I had also discussed signing with @edusperoni . He told me that @rigor789 was working on it. After he pushed his changes, I then added my updates on top of his changes.

If there are any suggestions or feedback to make this PR better, please let me know.

@rigor789
Copy link
Member

rigor789 commented Aug 4, 2023

@miladfm Thank you for working on this, at a quick glance this looks like a great set of changes. I'll try and get this merged by EOD, so it can get released on the next tag automatically.

@miladfm
Copy link
Contributor Author

miladfm commented Aug 4, 2023

Thank you @rigor789 I really appreciate it.
If there's anything else you need from me in the meantime, don't hesitate to let me know.

@rigor789
Copy link
Member

rigor789 commented Aug 6, 2023

Did a little cleanup pass, and added test cases, I'll merge this to main so it can get released to next to further test in projects. If anything else comes up we can address it in a follow up 👍

@rigor789 rigor789 merged commit ba3293c into NativeScript:main Aug 6, 2023
@miladfm
Copy link
Contributor Author

miladfm commented Aug 7, 2023

Thank you for your feedback, cleaning up the code, and adding the test cases.
Im ready to help address any future issues that may arise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants