feat(extensions): add extension podfile and setup extension with provision #5751
Conversation
…ision feat(extensions): allow multi podfile for different targets refactor(extensions): refactor extension podfile style: fix style syntax
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Nice work @miladfm! We have also been working around extensions lately so great timing 👍 |
|
Thank you @NathanWalker :) In our project, we're adding a new feature - a notification service to decrypt messages. To support this, I made some changes to the source code which we have tested in TestFlight and the App Store. I had also discussed signing with @edusperoni . He told me that @rigor789 was working on it. After he pushed his changes, I then added my updates on top of his changes. If there are any suggestions or feedback to make this PR better, please let me know. |
|
@miladfm Thank you for working on this, at a quick glance this looks like a great set of changes. I'll try and get this merged by EOD, so it can get released on the |
|
Thank you @rigor789 I really appreciate it. |
|
Did a little cleanup pass, and added test cases, I'll merge this to main so it can get released to |
|
Thank you for your feedback, cleaning up the code, and adding the test cases. |
This PR fixes the following open issue
#5520
#5244
PR Checklist
What is the current behavior?
Currently, the NativeScript CLI does not support Podfiles for extensions. The final Podfile is wrapped with the main application target. However, extensions require their own unique targets.
Additionally, it is currently not possible to build the iOS app with an extension and a provided team ID or provision.
What is the new behavior?
With this update, developers can now create a Podfile in each extension folder, similar to how they would for the main app. During the build process, the CLI will generate a new target with the extension name and merge it with the existing final Podfile. As a result, the Podfile, after the build, will contain plugins, App-Resources, and extension Podfiles.
Extension signing will inherit the signing style and team ID from the main app. If the build command contains the provision, the extension will also be signed with the provided provisions from the provisioning.json file located in the extension folder.