Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin add does not merge plugin's info.plist #797

Closed
teobugslayer opened this issue Aug 17, 2015 · 1 comment
Closed

Plugin add does not merge plugin's info.plist #797

teobugslayer opened this issue Aug 17, 2015 · 1 comment
Assignees
@teobugslayer
Labels
bug
Milestone
1.5.0

Comments

@teobugslayer
Copy link
Contributor

Consider following scenario: A developer wants to consume a {N} plugin which has custom info.plist using plugin add command.

In this scenario, {N} CLI looks for incorrectly named info.plist file in the plugin. Furthermore, the code does not correctly merge the contents of plugin info.plist file.
@teobugslayer teobugslayer added this to the 1.3.0 milestone Aug 17, 2015
@teobugslayer teobugslayer self-assigned this Aug 17, 2015
teobugslayer added a commit that referenced this issue Aug 17, 2015
@teobugslayer
Fix: look for correctly named info.plist when adding a plugin
f91d71e 
Fix: correctly merge plugin content when merging its info.plist

Fixes #797
@teobugslayer teobugslayer mentioned this issue Aug 17, 2015
Merged
@teobugslayer teobugslayer reopened this Aug 17, 2015
@vchimev vchimev modified the milestones: 1.3.1, 1.3.0 Sep 11, 2015
@vchimev
Copy link

vchimev commented Sep 11, 2015

The issue is reproducible with 1.3.0 release candidate.

@teobugslayer teobugslayer modified the milestones: 1.4.0, 1.3.1 Sep 28, 2015
@Fatme Fatme modified the milestones: 1.4.1, 1.4.0, 1.5.0 Oct 8, 2015
@vchimev vchimev closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teobugslayer teobugslayer

Labels
bug
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
3 participants
@Fatme @teobugslayer @vchimev