Fixed: typescript files don't show in {N} debugger. #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzraikov
force-pushed
the
raikov/fix-debug-ts
branch
from
ab97a55 to
061804b
Compare
| let deleteFilesFutures = allFiles.filter(file => minimatch(file, "**/*.ts", { nocase: true })).map(file => this.$fs.deleteFile(file)); | ||
| Future.wait(deleteFilesFutures); | ||
| if (this.$options.release) { | ||
| let deleteFilesFutures = allFiles.filter(file => minimatch(file, "**/*.ts", { nocase: true })).map(file => this.$fs.deleteFile(file)); |
There was a problem hiding this comment.
if and else statements are executing the same actions, the only difference is the pattern passed to minimatch. Is there a particular reason for splitting the two actions in if-else statement instead of modifying only the pattern?
tzraikov
force-pushed
the
raikov/fix-debug-ts
branch
from
061804b to
778e784
Compare
rosen-vladimirov
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.