fix(ios-inspector): Update cached inspector package to latest compatible version #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbektchiev
requested review from
Plamen5kov,
Mitko-Kerezov,
rosen-vladimirov,
ginev and
KristianDD
mbektchiev
force-pushed
the
bektchiev/fix-inspector-cache-update
branch
3 times, most recently
from
97b804d to
62b24c7
Compare
rosen-vladimirov
approved these changes
Jan 8, 2018
test/npm-installation-manager.ts
Outdated
| @@ -10,6 +10,7 @@ import * as StaticConfigLib from "../lib/config"; | |||
| import * as yok from "../lib/common/yok"; | |||
| import ChildProcessLib = require("../lib/common/child-process"); | |||
| import { SettingsService } from "../lib/common/test/unit-tests/stubs"; | |||
| import { ProjectDataService } from "../lib//services/project-data-service"; | |||
There was a problem hiding this comment.
../lib//services/ should be ../lib/services/
…st compatible version * Currently it is never updated and is left at the first version ever installed in `~/.local`. As a result newly published inspector packages are not used unless the user installs them explicitly in the project or deletes the cache manually. * The iOS inspector package version must be determined according to project's iOS runtime version instead of the version of CLI as it has been till now
mbektchiev
force-pushed
the
bektchiev/fix-inspector-cache-update
branch
from
62b24c7 to
525348f
Compare
ginev
approved these changes
Jan 8, 2018
mbektchiev
pushed a commit
that referenced
this pull request
Jan 9, 2018
…st compatible version (#3302) * Currently it is never updated and is left at the first version ever installed in `~/.local`. As a result newly published inspector packages are not used unless the user installs them explicitly in the project or deletes the cache manually. * The iOS inspector package version must be determined according to project's iOS runtime version instead of the version of CLI as it has been till now
dtopuzov
pushed a commit
that referenced
this pull request
Jan 10, 2018
* Generate debug port in range for Chrome DevTools websocket - iOS (#3275) * fix generating port for debug socket when debugging ios with chrome devtools When generating a port to start a websocket on, use the same logic as is present in the android debug service - get the first available available port in a range, and reuse it for the next debug session of the same application if it is still available * fix(device-socket): iOS Socket proxy should listen on IPv4 localhost adapter Check for available port is done on this adapter and by default server is launched on "::" which is IPv6's any adapter * Fix debug device/web socket closing (#2897) When we close the websocket we have to destroy the device socket as well. We need to wait the close event on the device socket instead of end. * fix(ios-inspector): Correctly update cached inspector package to latest compatible version (#3302) * Currently it is never updated and is left at the first version ever installed in `~/.local`. As a result newly published inspector packages are not used unless the user installs them explicitly in the project or deletes the cache manually. * The iOS inspector package version must be determined according to project's iOS runtime version instead of the version of CLI as it has been till now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~/.local.As a result newly published inspector packages are not used unless the user installs
them explicitly in the project or deletes the cache manually.
version instead of the version of CLI as it has been till now