Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect error is shown when xcrun simctl is not configured #3514

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

In case xcrun simctl throws some error, CLI does not handle it very well.
Improve the logic in ios-sim-portable and update its version in order to resolve the issue.

PR Checklist

What is the current behavior?

In case simctl is not configured correctly, CLI fails with process.send is not a function.

What is the new behavior?

CLI prints the message from simctl, which shows the user what is misconfigured

In case `xcrun simctl` throws some error, CLI does not handle it very well.
Improve the logic in ios-sim-portable and update its version in order to resolve the issue.
@rosen-vladimirov rosen-vladimirov added this to the 4.0.0 milestone Apr 3, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this Apr 3, 2018
@rosen-vladimirov rosen-vladimirov requested a review from Fatme April 3, 2018 09:53
@rosen-vladimirov rosen-vladimirov merged commit 5253501 into release Apr 3, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/update-ios-sim branch April 3, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants