Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate support for Node.js 6.x.x #3579

Merged
merged 1 commit into from
May 14, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented May 14, 2018

As Node.js 6.x.x is in maintenance mode, we deprecate support for it. We'll keep it deprecated until the usage of it is very low.

Disable support for Node.js 4.x.x and 5.x.x

Currently, when CLI is used with Node.js 4.x.x or 5.x.x, a warning has been shown. As we are deprecating support for Node.js 6.x.x and Node.js 4.x.x is near the end of its life, remove the support for Node.js versions below 6.x.x
In case Node.js 4.x.x is used, CLI will show error and will not execute the command. Node.js 4.x.x has been deprecated for some months.

PR Checklist

What is the current behavior?

CLI allows using Node.js 4, 5, 6. In case Node.js 4.x.x or 5.x.x is used, CLI prints a warning on each command.

What is the new behavior?

CLI does not allow using Node.js 4.x.x and 5.x.x - each command fails immediately.
In case Node.js 6.x.x is used, CLI prints warning that support for Node.js 6.x.x is deprecated.

Implements #3581 and #3582

@rosen-vladimirov rosen-vladimirov added this to the 4.1.0 milestone May 14, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this May 14, 2018
@rosen-vladimirov rosen-vladimirov requested a review from Fatme May 14, 2018 11:05
As Node.js 6.x.x is in maintenance mode, we deprecate support for it. We'll keep it deprecated until the usage of it is very low.

Disable support for Node.js 4.x.x and 5.x.x

Currently, when CLI is used with Node.js 4.x.x or 5.x.x, a warning has been shown. As we are deprecating support for Node.js 6.x.x and Node.js 4.x.x is near the end of its life, remove the support for Node.js versions below 6.x.x
In case Node.js 4.x.x is used, CLI will show error and will not execute the command. Node.js 4.x.x has been deprecated for some months.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/node6-deprecation branch from c6b7054 to c91f534 Compare May 14, 2018 14:25
@rosen-vladimirov rosen-vladimirov merged commit 9bbb2e1 into master May 14, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/node6-deprecation branch May 14, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants