Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): isValidNativeScriptProject returns incorrect result #3580

Merged
merged 1 commit into from
May 14, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

In case CLI is used as a library and isValidNativeScriptProject is called multiple times, it does not return correct results after the first time.
The problem is that it uses the singleton object - projectData. Change the implementation to use projectDataService, this way the method will always return correc results.

PR Checklist

What is the current behavior?

In case CLI is used as a library and isValidNativeScriptProject is called multiple times, it does not return correct results after the first time.

What is the new behavior?

In case CLI is used as a library and isValidNativeScriptProject is called multiple times, it returns correct results.

In case CLI is used as a library and `isValidNativeScriptProject` is called multiple times, it does not return correct results after the first time.
The problem is that it uses the singleton object - projectData. Change the implementation to use projectDataService, this way the method will always return correc results.
@rosen-vladimirov rosen-vladimirov added this to the 4.1.0 milestone May 14, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this May 14, 2018
@rosen-vladimirov rosen-vladimirov requested a review from Fatme May 14, 2018 11:50
@rosen-vladimirov rosen-vladimirov merged commit f4598fe into master May 14, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-isValidNsProject branch May 14, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants