Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tracking for used Debug tool is incorrect #3589

Merged
merged 1 commit into from
May 17, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented May 15, 2018

The tracking if Inspector or Chrome is used as a debug tool is incorrect - currently it sends "Inspector" when --inspector is not specified. Chrome is sent only when --chrome is passed.
Fix the tracking and add tests.

PR Checklist

What is the current behavior?

Tracking for used debug tools is not correct - "Chrome" is the default option, but it is tracked only when --chrome is passed.

What is the new behavior?

Tracking sends correct information when Inspector is used and when Chrome is used.

Fixes #3593

The tracking if Inspector or Chrome is used as a debug tool is incorrect - currently it sends "Inspector" when `--inspector` is not specified. `Chrome` is sent only when `--chrome` is passed.
Fix the tracking and add tests.
@rosen-vladimirov rosen-vladimirov added this to the 4.1.0 milestone May 15, 2018
@rosen-vladimirov rosen-vladimirov self-assigned this May 15, 2018
@rosen-vladimirov rosen-vladimirov merged commit 04ef22f into master May 17, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-inspector-tracking branch May 17, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants