fix: Detect iOS devices connected by USB only #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently CLI detects iOS Devices with Wi-Fi sync enabled. However, we can only detect them, but we are not able to deploy and livesync applications on them. This also breaks the workflow with devices connected by USB, but with Wi-Fi sync enabled. So detect only the USB connected devices and disregard the ones connected with Wi-Fi sync enabled. This is handled in the 0.4.11 version of ios-device-lib, so just update the version
Fatme
approved these changes
May 17, 2018
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CLI detects iOS Devices with Wi-Fi sync enabled. However, we can only detect them, but we are not able to deploy and livesync applications on them. This also breaks the workflow with devices connected by USB, but with Wi-Fi sync enabled.
So detect only the USB connected devices and disregard the ones connected with Wi-Fi sync enabled. This is handled in the 0.4.11 version of ios-device-lib, so just update the version: https://github.com/telerik/ios-device-lib/releases/tag/v0.4.11
PR Checklist
What is the current behavior?
Devices with Wi-Fi sync enabled are detected by CLI, but it cannot work with them. Also devices connected with USB cable and Wi-Fi sync enabled are not usable as CLI fails to deploy/livesync the applications.
What is the new behavior?
Devices with Wi-Fi sync enabled are not detected anymore.
Devices connected with USB cable and Wi-Fi sync enabled can be used without interruption.
Fixes #1398