Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file references inside .pbxproject are incorrect when there's space in project path #3729

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 5, 2018

{N} CLI is not able to build a native project in case when the project name contains a space. In this case the filePaths inside HEADER_SEARCH_PATHS sections are not valid. Actually this PR fixes 2 problems.
The first is that the added filePath is full file path, so this PR changes this and makes the paths relative.
The second thing is that the filePath does not contain " ", so this PR adds "" around the filePath.

Steps to reproduce:

  1. tns create "my space app"
  2. Change the version of tns-core-modules to next
  3. tns build ios

PR Checklist

@Fatme
Copy link
Contributor Author

Fatme commented Jul 6, 2018

run ci

1 similar comment
@Natalia-Hristova
Copy link

run ci

@rosen-vladimirov rosen-vladimirov force-pushed the fatme/update-node-xcode branch from 0182d43 to cc096f1 Compare July 6, 2018 13:51
@Natalia-Hristova Natalia-Hristova added this to the 4.2.0 milestone Jul 6, 2018
@Fatme
Copy link
Contributor Author

Fatme commented Jul 9, 2018

run ci

2 similar comments
@dtopuzov
Copy link
Contributor

dtopuzov commented Jul 9, 2018

run ci

@Natalia-Hristova
Copy link

run ci

@Fatme Fatme merged commit cb9e050 into master Jul 9, 2018
@Fatme Fatme deleted the fatme/update-node-xcode branch July 9, 2018 16:32
@rosen-vladimirov rosen-vladimirov changed the title fix: Fix file references inside .pbxproject fix: file references inside .pbxproject are incorrect when there's space in project path Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants